Back to the Meeting Notes List
!! Theme Refactor (bharat) We decided that our theming system was inadequate and that we should not release a final beta without fixing it. having separate layouts and themes was proving to be too confusing and difficult to support. Having separate CSS and template files that lived in 3 different places (gallery2/templates, gallery2/themes, gallery2/layouts) was also very confusing. Having too much logic in the smarty template files was confusing. I set out to refactor this such that there's a single theme that controls the look and feel of the application and that has control over every page this is now mostly done. the theme code controls 6 page types: album, photo, module, admin, error, progress-bar in the process I've broken out most of the functionality into blocks that you can position anywhere on the page. I've completely redone the way that we do immediate-status views so that the code is actually executed at template execution time
(valiant) why differentiate between album and photo? is this singleItem vs albumItem?
(bharat) yes. the logic is significantly different so I felt that it would be easier on the themer to differentiate.
(valiant) ok
(bharat) It's a huge change, but I'm at the point now where everything works, including all of the edge cases that I've discovered except for a few small things one problem is that if we get an error during a progress-bar view, we don't have a clean way to render it. another problem is that our progress bar views break the nice encapsulation that we get when we're embedded (but that's a pre-existing problem) I've made one round of my code available to mindless and valiant for review. I will be ready for a second round for review by the end of the weekend. My guess is that I'll be done, barring issues discovered during review by the end of the weekend
(bharat) oh, as part of this I am going to delete layouts: hybrid, tile, slider, themes: mblue, veloria (mindless) i'll work on reviving them later
(mindless): Is it worth it to detect broken images as part of the upgrade for valiant's task (http://sourceforge.net/pm/task.php?func=detailtask&project_task_id=115692&group_id=7130&group_project_id=14056) (bharat): I consider that a nice-to-have, but not necessary for B4 (valiant): i'll do it if i find time
(bharat): theme refactor goes in by 7/6, B4 goes out on 7/13. That leaves us one month. Tentative schedule:
the new sf.net project (gallery-contrib), who does code reviews (SoCers should send patches to their mentors).
Back to the Meeting Notes List
